Skip to content

Checkout Kani and CBMC in parallel directories and install Kani dependencies before building CBMC from source - #2161

Merged
zhassan-aws merged 3 commits into
model-checking:mainfrom
zhassan-aws:fix2-nightly-cbmc
Jan 27, 2023
Merged

zhassan-aws merged 3 commits into
model-checking:mainfrom
zhassan-aws:fix2-nightly-cbmc

Conversation

@zhassan-aws

Copy link
Copy Markdown
Contributor

Description of changes:

This PR fixes the nightly CBMC regressions, which got broken by #2142. The PR does the following:

  1. Checks out Kani and CBMC in parallel directories to avoid the issue with the CBMC build complaining about being inside the Kani workspace
  2. It adds an input parameter to the setup action to allow the action to work if Kani is checked out in a directory other than "."
  3. It reverses the order so that the Kani dependencies (including a CBMC release) are installed first before building CBMC from source, so that the built-from-source binaries override the release ones

Resolved issues:

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested? CI

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws
zhassan-aws requested a review from a team as a code owner January 26, 2023 19:30
@zhassan-aws zhassan-aws mentioned this pull request Jan 26, 2023
4 tasks done
@zhassan-aws
zhassan-aws merged commit 3d02a42 into model-checking:main Jan 27, 2023
@zhassan-aws
zhassan-aws deleted the fix2-nightly-cbmc branch January 27, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants